Remove Windows NDK symlink and run apk check + build in separate steps#118
Merged
MarijnS95 merged 2 commits intorust-mobile:masterfrom Jan 28, 2021
Merged
Conversation
An obscure one-line `apk build` failure got shadowed by a much larger deprecation warning shown by `cargo check` right above, deemed irrelevant. Separating these steps will make it clear when the issue is code-related (ndk, ndk-glue) or build-related (ndk-build, cargo-apk, cargo-subcommand).
In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile#92 [2]: actions/runner-images#2343
Member
Author
Ha, very funny. Build-tested this before to make sure the images have been deployed, turns out mine uses |
dvc94ch
approved these changes
Jan 27, 2021
Member
Author
|
Hey, the CI magically re-ran 35 mins ago! Just ran into the inverse error here: https://github.com/MarijnS95/android-ndk-rs/runs/1786432472?check_suite_focus=true: New-Item: D:\a\_temp\36b3b79e-1665-493e-8ec0-69903de7a78a.ps1:4
Line |
4 | New-Item -Path $sdk_root -ItemType SymbolicLink -Value $oldAndroidPat …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Cannot create symbolic link because the path C:\Android already exists.Time to merge! |
Contributor
I kicked it off again 😄 |
Member
Author
|
Had a hunch, thanks! The issue was anyway reopened with the "awaiting deployment" flag: actions/runner-images#1122 (comment) but it looks like it reached us already :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An obscure one-line
apk buildfailure got shadowed by a much larger deprecation warning shown bycargo checkright above, deemed irrelevant. Separating these steps will make it clear when the issue is code-related (ndk, ndk-glue) or build-related (ndk-build, cargo-apk, cargo-subcommand).GH actions virtual environments have finally been fixed to provide a space-less path to the SDK and NDK by default 🎉. The workaround - introduced in #92 - can finally be removed again!