-
Notifications
You must be signed in to change notification settings - Fork 122
Closed
Labels
difficulty: easyLikely easier than most tasks hereLikely easier than most tasks herestatus: needs discussionDirection must be ironed outDirection must be ironed outtype: questionThere's no such thing as a stupid oneThere's no such thing as a stupid one
Description
Features thus far seem to be used specifically in ndk-sys to prevent linking against additional libraries, for content that is provided outside of libandroid.so:
However, hardware_buffer and trace have their content available directly in libandroid.so - making these features only guard Rust code, in my eyes unnecessarily. It seems much more clear to enable everything libandroid.so has to offer solely when a certain API level is turned on. After all, we don't replicate this feature guarding pattern for other "subsystems" of the Android API, only for tracing and hardware_buffer.
@JasperDeSutter What's your thought on this?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
difficulty: easyLikely easier than most tasks hereLikely easier than most tasks herestatus: needs discussionDirection must be ironed outDirection must be ironed outtype: questionThere's no such thing as a stupid oneThere's no such thing as a stupid one