Skip to content

Split things into different files, to optimize future work#85

Merged
Nercury merged 2 commits into
masterfrom
refactor-structure
Mar 4, 2025
Merged

Split things into different files, to optimize future work#85
Nercury merged 2 commits into
masterfrom
refactor-structure

Conversation

@Nercury

@Nercury Nercury commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

Not much change besides the simple divide and conquer.

@Nercury Nercury requested a review from MarijnS95 March 4, 2025 14:52
@Nercury

Nercury commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator Author

@dextero I want this to land before #84

@MarijnS95 MarijnS95 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! rustfmt still needs to be ran and I think that should be(come) a requirement in the CI?

EDIT: I didn't really vet the changes at all but trust you moved it completely - CI is happy so the imports / module references should all be good.

Comment thread src/arrays.rs Outdated
Comment thread src/arrays.rs Outdated
@Nercury

Nercury commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator Author

Nice idea! rustfmt still needs to be ran and I think that should be(come) a requirement in the CI?

EDIT: I didn't really vet the changes at all but trust you moved it completely - CI is happy so the imports / module references should all be good.

I have added basic rustfmt config. Other PRs can take care of that if that's important.
I tried to leave the public facing api exactly the same. Later the better names could be found for modules if necessary, but the single file was getting unwieldy.

@Nercury Nercury merged commit 151aefc into master Mar 4, 2025
@MarijnS95

Copy link
Copy Markdown
Member

I have added basic rustfmt config. Other PRs can take care of that if that's important.

Oh I didn't need a rustfmt.toml config; if anything the edition set now should by default be fetched from Cargo.toml?

I meant running it in CI to reject changes if they don't adhere to the (default!) formatting standard, instead of causing unnecessary reformatting churn later on.

@Nercury

Nercury commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator Author

I have added basic rustfmt config. Other PRs can take care of that if that's important.

Oh I didn't need a rustfmt.toml config; if anything the edition set now should by default be fetched from Cargo.toml?

I meant running it in CI to reject changes if they don't adhere to the (default!) formatting standard, instead of causing unnecessary reformatting churn later on.

It's ok I formatted with rustfmt now :)

@Nercury Nercury deleted the refactor-structure branch March 4, 2025 15:38
@MarijnS95

Copy link
Copy Markdown
Member

Oh yeah I trust that you formatted it now, just thinking it'd be nice to validate this in CI going forward for future contributions and pushes, as done in #86 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants