This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Create simple dep-graph from Cargo metadata#441
Merged
nrc merged 1 commit intorust-lang:masterfrom Aug 14, 2017
Merged
Conversation
Incomplete `build::plan::Plan` is created, containing an inter-package dependency graph and targets/features of packages in the workspace scope, and stored when performing the Cargo build routine. It's not currently used and specific data held will require further design and work. For now copies some of the Cargo types, as it's not yet publicly exposed.
nrc
reviewed
Aug 14, 2017
| let build_plan = create_plan(&ws).unwrap(); | ||
| compilation_cx_access.build_plan = Some(build_plan); | ||
| // Release the lock on the compilation_cx | ||
| mem::drop(compilation_cx_access); |
Member
There was a problem hiding this comment.
Could we use a scope rather than mem::drop? Or better, drop the lock and pick it up again here?
Contributor
Author
There was a problem hiding this comment.
We definitely could lock twice if that's not a problem, I just tried to avoid that here. Using a scope would need to resurface ws and config, but unsure if the borrows permit that, I'll have to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete
build::plan::Planis created, containing an inter-package dependency graph and targets/features of packages in the workspace scope, and stored when performing the Cargo build routine.It's not currently used and specific data held will require further design and work.
For now copies some of the Cargo types, as some members are not yet publicly exposed.