This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Provide CompletionItem.kind for Racer completions#237
Merged
nrc merged 2 commits intorust-lang:masterfrom Apr 2, 2017
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #74 (Provide CompletionItem.kind from Language Server Protocol).
Right now we have a generic wrench icon applied to every completion:
After mapping from MatchType in Match from Racer completion results to an appropriate CompleteItemKind we get:
Not sure if the mapping is implemented in the right place - I only got inspired by already existing mapping function
source_kind_from_def_kindinlsp_data.rs. This is obviously just an idea how we could do that.We could even introduce mapping for
CompletionItemKind::Constructorlater on, for example for functions that return an owned version of Self, when we'll be able to retrieve a proper function signature. Until then we could possibly provide heuristics for functions calledneworfromif needed.