This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Stubbed out separate simple test projects for tests#231
Merged
nrc merged 2 commits intorust-lang:masterfrom Mar 26, 2017
Merged
Stubbed out separate simple test projects for tests#231nrc merged 2 commits intorust-lang:masterfrom
nrc merged 2 commits intorust-lang:masterfrom
Conversation
nrc
approved these changes
Mar 26, 2017
Member
nrc
left a comment
There was a problem hiding this comment.
Looks good. There are a couple of the toml files which are copied without changes, I think the name field in these should be changed.
| [root] | ||
| name = "hello" | ||
| version = "0.1.0" | ||
|
|
Member
There was a problem hiding this comment.
I would leave the lock file checked in and add lock files for the other tests
Contributor
Author
|
Added relevant Cargo.lock files. It seems that name field in Cargo.toml files do match the project name. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small progress for multithreaded testing (#155).
Until we configure separate cargo build paths we can use simple test projects to separate those build paths eliminating risk of possible concurrent access/blocking, which brings us one step closer to concurrent tests.
@nrc Filled you as the projects' author, I hope you don't mind :)