Skip to content

Add FLS team #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackh726 merged 1 commit into from
Oct 23, 2025
Merged

Add FLS team #2028

jackh726 merged 1 commit into from
Oct 23, 2025
+70 −1

Conversation

@traviscross
Copy link
Contributor

@traviscross traviscross commented Oct 21, 2025 •
edited
Loading

Back in May 2025, we adopted the FLS into the Project. It's now time to create a team charged with maintaining and improving this document. Pete LeVasseur has graciously volunteered to lead this team, and we're all excited to see where he and the team can take it.

The initial charter of the FLS team is:

The FLS Team maintains and improves the FLS for the benefit of the Project and the safety-critical community.

The FLS Team is responsible for:

  • Maintaining and improving the content and tooling of the FLS.
  • Keeping the FLS up to date with new releases of Rust.
  • Setting and documenting guidelines for authorship and contribution to the FLS.
  • Working with the safety-critical community to ensure the FLS continues to serve them, particularly with regard to supporting the qualification of Rust-related tools.
  • Working with other Rust teams to ensure the accuracy of content in the FLS.
  • Working with the maintainers of the Reference to identify areas where each document and team can provide value to the other.
  • Cultivating and curating membership of fls-contributors and setting policies for that team.

The FLS Team leads are tasked with ensuring the health of the team. The team manages its own membership and selects its own leads.

The initial charter of the FLS contributors team is:

The FLS Contributors Team supports the work of the FLS Team in maintaining and improving the FLS.

The FLS Contributors Team is responsible for:

  • Proposing updates and improvements to the FLS, following the guidance of the FLS Team.
  • Working with members of the FLS Team to refine and integrate those changes.
  • Reviewing pull requests and suggesting improvements to them.
  • Identifying changes to the FLS relevant to the Reference and filing Reference issues or submitting Reference PRs.
  • Triaging issues and pull requests.

The FLS Contributors team does not have any leads and its membership is managed by the FLS Team. The team is a subteam of the FLS Team.

The FLS contributors team is starting out with no members, but there are some immediate candidates, and it's expected these will be added soon.

@PLeVasseur @ehuss @tshepang @nikomatsakis @rust-lang/spec @rust-lang/lang-docs @rust-lang/lang

@traviscross
Add FLS team
bb93173 
Back in May 2025, we [adopted] the FLS into the Project.  It's now
time to create a team charged with maintaining and improving this
document.  Pete LeVasseur has graciously volunteered to lead this
team, and we're all excited to see where he and the team can take it.

[adopted]: https://blog.rust-lang.org/2025/03/26/adopting-the-fls/
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    📝 Editing team 'rust-lang/all':
      Adding member 'AlexCeleste' with member role
    ➕ Creating team:
      Org: rust-lang
      Name: fls
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        AlexCeleste: member
        PLeVasseur: member
        traviscross: member
        tshepang: member
    ➕ Creating team:
      Org: rust-lang
      Name: fls-contributors
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/fls':
      Permission Changes:
        Giving team 'fls' write permission
        Giving team 'fls-contributors' triage permission
        Giving team 'lang-ops' write permission
        Changing team 'spec-contributors''s permission from write to triage
    ➕ Creating repo:
      Org: rust-lang
      Name: fls-team
      Description: Home of the Rust FLS team
      Homepage: None
      Auto-merge: true
      Permissions:
        Giving team 'fls' maintain permission
        Giving team 'fls-contributors' triage permission
        Giving team 'lang' maintain permission
        Giving team 'lang-docs' maintain permission
        Giving team 'lang-ops' maintain permission
        Giving team 'spec' maintain permission
        Giving team 'spec-contributors' triage permission
        Giving user 'rustbot' write permission
        Giving user 'rust-rfcbot' write permission
      Branch Protections:

@traviscross traviscross marked this pull request as ready for review October 21, 2025 23:31
PLeVasseur
PLeVasseur approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together @traviscross

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team and removed S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Oct 22, 2025
jackh726
jackh726 reviewed Oct 22, 2025
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal review, not as team repo admin.

repos/rust-lang/fls.toml
Comment on lines 10 to +14
lang = "write"
lang-docs = "write"
lang-ops = "write"
spec = "write"
spec-contributors = "write"
spec-contributors = "triage"
Copy link
Member

@jackh726 jackh726 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: if the team has been delegated the maintenance and responsibility of the fls, then I'm not sure why these teams need to be added on this.

Copy link
Contributor

@PLeVasseur PLeVasseur Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a fair point. I don't have enough background here to feel strongly either way.
Perhaps someone who's got more of that background could chime in here.

Copy link
Contributor Author

@traviscross traviscross Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're exploring more lang involvement in specification efforts generally, and we're of course interested in collaboration between the Reference and the FLS. The FLS team will be in charge of doing merges, but the other perms are needed even to edit PR descriptions or titles. It's painful, e.g. from the lang-ops side, to not be able to affect these things for issues lang is involved with (and Tomas is on lang-ops but not FLS). I think we can trust people on these teams to not overstep the social contract of what is fully within the FLS team's discretion.

jackh726
jackh726 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval as team repo admin after Niko approves

@nikomatsakis nikomatsakis mentioned this pull request Oct 22, 2025
Open
5 tasks
@traviscross
Copy link
Contributor Author

traviscross commented Oct 22, 2025

This has now been approved by the lead of the team being created, the lead of the parent team, and by both leads of lang-docs, another interested party in this matter. This is OK to merge.

JohnTitor
JohnTitor reviewed Oct 22, 2025
View reviewed changes
teams/fls.toml
[website]
name = "FLS team"
description = "Maintaining and improving the FLS"
repo = "http://github.com/rust-lang/fls-team"
Copy link
Member

@JohnTitor JohnTitor Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you create a new repo or did you mean https://github.com/rust-lang/fls?

Copy link
Contributor Author

@traviscross traviscross Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR creates the fls-team repo.

@jieyouxu jieyouxu added S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. and removed needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team labels Oct 23, 2025
@jackh726 jackh726 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into rust-lang:master with commit 210bf33 Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackh726 jackh726 jackh726 approved these changes

+5 more reviewers

@PLeVasseur PLeVasseur PLeVasseur approved these changes

@JohnTitor JohnTitor JohnTitor left review comments

@ehuss ehuss ehuss approved these changes

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@tshepang tshepang tshepang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@traviscross @ehuss @nikomatsakis @tshepang @PLeVasseur @JohnTitor @jackh726 @jieyouxu