Conversation
rami3l
approved these changes
Apr 4, 2025
Member
rami3l
left a comment
There was a problem hiding this comment.
LGTM! Just don't forget to adjust the target features in run.bash accordingly...
rami3l
reviewed
Apr 4, 2025
ChrisDenton
approved these changes
Apr 4, 2025
Member
ChrisDenton
left a comment
There was a problem hiding this comment.
lgtm but will this require any changes in our release process?
Contributor
Author
Why would it? I think we still build the rustup crate, whose features have not changed. |
804d055 to
764a96c
Compare
rami3l
approved these changes
Apr 7, 2025
This was referenced Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another step towards #3790. Also in #2626 it was noted that curl is imposing substantial overhead on startup time, even when it is not being used.