Fix compile on rust nightly#3364
Merged
rbtcollins merged 1 commit intomasterfrom May 28, 2023
unknown repository
Merged
Conversation
xen0n
reviewed
May 25, 2023
Contributor
xen0n
left a comment
There was a problem hiding this comment.
In my own experiments this only happens with the reqwest-rustls-tls feature disabled but reqwest-backend and reqwest-default-tls enabled. Given the context of your work that's loongarch64 enablement, maybe mentioning the intended use case (no ring yet, so no reqwest-rustls-tls) would further justify the change.
Contributor
Author
|
r? @hi-rustin |
rbtcollins
suggested changes
May 28, 2023
| use std::time::Duration; | ||
|
|
||
| use anyhow::{anyhow, Context, Result}; | ||
| #[cfg(feature = "reqwest-rustls-tls")] |
Contributor
There was a problem hiding this comment.
Please just put a any in here with the additional feature that requires rustls.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compile on rust nightly (1.71.0-nightly) with non-default features:
Compile errors