Fix most of clippy warnings#1754
Conversation
90a6287 to
f1ae991
Compare
|
Wow, this is a big PR. It will need to take quite a bit of time to be able to review it all. But thank you for doing this work. If anyone else wants to review this, please please tell me, otherwise I'll try and set aside an hour or so soon. |
|
Rebased on master. |
|
☔ The latest upstream changes (presumably #1744) made this pull request unmergeable. Please resolve the merge conflicts. |
nrc
left a comment
There was a problem hiding this comment.
Looks good, thanks! I had one comment, but you can ignore it. Needs a rebase
|
Rebased on master. |
|
If you could fold the formatting updates into whichever commit they belong then I'm OK to merge this |
|
Did you mean to squash the entire branch into one commit? If so then that's fine, but if you meant to keep the different fixes independent then you might want to sort that out :D |
|
I squashed this to one commit because all those small commits only serve |
Note: Feel free to squash this PR.
There are 3 remained warnings:
Remaining clippy warnings