track configs set from cli flags#6253
Merged
calebcartwright merged 1 commit intorust-lang:masterfrom Jul 27, 2024
Merged
Conversation
a809f01 to
e822e97
Compare
Member
Author
|
As a thought for future cleanup on this, I think perhaps we can expand the programmatic config setting logic to take an argument indicating whether it's a user supplied value or a rustfmt internal override like one of these: Line 760 in e21c1e2 And then the config setter logic can use that to determine whether or not to flip the flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6252
There's more detail in that linked issue, but rustfmt internally needs to know whether the user explicitly specified a configuration value via a top level cli flag, e.g.
--editionor--style-edition. This PR adds a separate boolean flag on configuration options that indicates whether the user specified it via a top level cli flag.Notably, this intentionally does not make any changes to the
config.set().*calls, nor theconfig.was_set().*behavior. That's because I'm unclear on the historical reasons why those ignored the CLI flag method, at this time I'm unclear on the potential side effects of changing that behavior, and we don't need to resolve nor risk any of that for the purposes of the 2024 work (i left an inline FIXME to revisit)