Fix: ICE with expanded code #6105#6112
Merged
ytmimi merged 5 commits intorust-lang:masterfrom Mar 17, 2024
Merged
Conversation
Contributor
|
@Tanjaint21 thanks for helping out with this one. When you have a moment could you add the code snippet listed in #6105 (comment) as a test case. It would also be great if you could add a test case for the code snippet in #5885 as I believe that we should no longer panic when reformatting that macro. |
Contributor
Author
Contributor
|
Awesome! one last ask. When you get a second can you add these new files to this test. I've been adding test cases here to prevent any regressions. |
ytmimi
approved these changes
Mar 17, 2024
Contributor
|
Thanks again for your help on this one, and cheers on your first contribution to rustfmt 🎉 |
11 tasks
|
Thanks for fixing those! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustfmtICE with expanded code #6105src/tools/rustfmt/src/expr.rs:407:13#5885This is my first pull request 🎉
In this, I am fixing this issue as per suggested by @ytmimi
Thank You.