Prevent ICE when calling parse_attribute without an attribute#5732
Merged
calebcartwright merged 1 commit intorust-lang:masterfrom Jun 19, 2023
Merged
Prevent ICE when calling parse_attribute without an attribute#5732calebcartwright merged 1 commit intorust-lang:masterfrom
calebcartwright merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
I feel like this is probably a pebcak issue, but I'm puzzled why the change we're making is dealing with the first token following the keyword not being a Am I misunderstanding and/or missing something obvious? I would've thought the test input we'd use would include some non- cfg_if::cfg_if! {
if {
} else if #(&cpus) {
} else [libc::CTL_HW, libc::HW_NCPU, 0, 0]
} |
Contributor
Author
|
@calebcartwright Thank you for catching that. We should be using the snippet from the referenced issue. While I was investigating what was going on I modified the snippet by adding the |
Fixes 5729 `parse_attribute` will panic if the first token is not a `#`. To prevent this we return early instead of trying to parse an invalid attribute.
calebcartwright
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5729
parse_attributewill panic if the first token is not a#. To prevent this we return early instead of trying to parse an invalid attribute.