Fix sig::add_or_sub and IeeeFloat::normalize#21
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Jun 11, 2025
Merged
Conversation
Contributor
Author
Member
|
Also Cc @eddyb in case you are still involved with apfloat :D |
Contributor
Author
|
Ping reviewer @tgross35 |
tgross35
approved these changes
Jun 11, 2025
Contributor
tgross35
left a comment
There was a problem hiding this comment.
I'm not very familiar with this codebase but the logic makes sense, matches what was accepted for LLVM, and seems well tested. Sorry for the delay, thanks for the fix!
Contributor
|
Released in v0.2.3+llvm-462a31f5a5ab |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust version of llvm/llvm-project#98721.
Fixes #11
cc @RalfJung