Clean up commands #685
Merged
Clean up commands #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `bench_commit` can be done with `bench_local` after running `rustup-install-toolchain-master` on the relevant commit. - `remove_benchmark` and `remove_errs` are listed in the help but not implemented. The commit also tweaks the language in the help message, for consistency.
- `process()` matches the command `process`. - `bench()` matches the prefix of the commands `bench_published` and `bench_local`, and it isn't limited to a particular commit.
ffc1ef7 to
80d141e
Compare
For consistency with the other `bench_*` commands.
`TOOLCHAIN` is more standard terminology (e.g. it's what `rustup` uses), and can't be confused with the `ID` used by `bench_local` and `profile` for identifying benchmark results.
80d141e to
11634a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with #683.