You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you very much! I think that this is already in a pretty good shape (would be nice to eventually split the large function into a bunch of smaller once, but that's a detail).
In terms of the dependencies, the dependency count goes up from 307 to 329. However, if we get rid of inquire, which shouldn't be needed since we now got ratatui, it goes down to 321. And if we later also get rid of tabled, it goes back down to 309 :)
If you're up for it, it would be nice to get rid of inquire. Instead of the metric selection dialog, we could have a "select box" of metrics in the main TUI, with instructions being the default. Instead of the artifact selection dialog, we could have another ratatui screen that displays a table of artifacts and lets the user choose the ones they want to compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mainmatter/eurorust-2024-impl-Room#9
Warning
This is a PoC - expect hackathon code quality!