Merged
Conversation
bfd84ba to
c6b122d
Compare
nnethercote
commented
Apr 28, 2022
lqd
approved these changes
Apr 28, 2022
Member
lqd
left a comment
There was a problem hiding this comment.
It's indeed a great find. 40% of the compilation is in specialization_graph_of and evaluate_obligation, which is close to nalgebra as you said (although in different proportions) but 20x faster to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final new benchmark I intend to add. I think it's a good choice because it stresses trait handling in very interesting ways, and in ways that are quite similar to
nalgebra, which is another interesting case. However,bitmapsis much smaller thannalgebra, so it doesn't eat into our CI budget nearly as much.End to end compile times:
Final crate compile times vs
helloworld: