Skip to content

Don't lint large_stack_array inside static items#9466

Merged
bors merged 1 commit intorust-lang:masterfrom
lukaslueg:issue9460
Sep 12, 2022
Merged

Don't lint large_stack_array inside static items#9466
bors merged 1 commit intorust-lang:masterfrom
lukaslueg:issue9460

Conversation

@lukaslueg
Copy link
Copy Markdown
Contributor

We now check if the linted Expr is inside an ItemKind::Static, which can't take the suggested Box<[...]. I think this is the correct fix for #9460

I removed if_chain while I was at it.

changelog: Don't lint large_stack_array inside static items

@rust-highfive
Copy link
Copy Markdown

r? @dswij

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2022
Copy link
Copy Markdown
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this

@dswij
Copy link
Copy Markdown
Member

dswij commented Sep 12, 2022

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Sep 12, 2022

📌 Commit 6f41a44 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Copy Markdown
Contributor

bors commented Sep 12, 2022

⌛ Testing commit 6f41a44 with merge cdf26de...

@bors
Copy link
Copy Markdown
Contributor

bors commented Sep 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing cdf26de to master...

@bors bors merged commit cdf26de into rust-lang:master Sep 12, 2022
@lukaslueg lukaslueg deleted the issue9460 branch September 12, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants