Add disallowed_type lint, this adds a field to the conf struct#7315
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 10, 2021
Merged
Add disallowed_type lint, this adds a field to the conf struct#7315bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Looks like someone brought ICE to the party! CI failed because of 2 different ICE panics maybe just one? |
giraffate
suggested changes
Jun 7, 2021
2b008d8 to
e57441a
Compare
giraffate
reviewed
Jun 8, 2021
giraffate
approved these changes
Jun 9, 2021
Contributor
giraffate
left a comment
There was a problem hiding this comment.
It looks good, thanks! Can you squash commits?
Replace use of node_type -> node_type_opt, fix clippy warnings Don't walk the hir unnecessarily let the visitor do it
Contributor
Author
|
Squashed. |
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit ea45e2a has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jun 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7277
changelog: Add
[`disallowed_type`]a lint that can enforce banning types specified in the config.