r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

You are right. I think the proper fix might be changing const-eval equivalence of two exprs from default to an option.

You are right. I think the proper fix might be changing const-eval equivalence of two exprs from default to an option.

Can't you just check that the constant belongs to an inherent impl and not a trait?

Wouldn't this work?

                    && let Some((DefKind::AssocConst { .. }, did)) = self.typeck.type_dependent_def(id)
                    && self.tcx.inherent_impl_of_assoc(did).is_some() =>

That is correct. The only thing you need to do is make sure the constant is from an inherent impl and not a trait impl.

Indeed. Thanks for both of you :)

Though what I'm considering is that is it really proper for match_same_arms to consider exprs evaluting to the same constant as same, for example:

match true {
    false => 1 + 1,
    true => 0 + 2,
};