Skip to content

clean-up unnecessary_map_or and manual_is_variant_and #16386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jarcho merged 1 commit into from
Jan 12, 2026
Merged

clean-up unnecessary_map_or and manual_is_variant_and #16386

Jarcho merged 1 commit into from
Jan 12, 2026
+111 −99

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Jan 12, 2026

This is the first commit of #16383

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a mentioned this pull request Jan 12, 2026
Open
@github-actions
Copy link

github-actions bot commented Jan 12, 2026 •
edited
Loading

Lintcheck changes for 2b50456

Lint Added Removed Changed
clippy::unnecessary_map_or 0 0 22

This comment will be updated if you push new changes

@ada4a
Copy link
Contributor Author

ada4a commented Jan 12, 2026 •
edited
Loading

merged in #16387 (EDIT: oops, no, the two PRs are independent)

@ada4a ada4a closed this Jan 12, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 12, 2026
@ada4a ada4a reopened this Jan 12, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 12, 2026
@ada4a ada4a force-pushed the unnecessary_map_or-cleanup branch from 5b6dd22 to ee8c1ee Compare January 12, 2026 12:31
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Jarcho
Jarcho requested changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on function names since you're already changing things.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ada4a
clean-up unnecessary_map_or and manual_is_variant_and
2b50456 
- manual_is_variant_and: create `Flavor` using a function
  - removes one level of `for`
@ada4a ada4a force-pushed the unnecessary_map_or-cleanup branch from ee8c1ee to 2b50456 Compare January 12, 2026 12:45
@ada4a
Copy link
Contributor Author

ada4a commented Jan 12, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 12, 2026
Jarcho
Jarcho approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Jan 12, 2026
Merged via the queue into rust-lang:master with commit 5ef494c Jan 12, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 12, 2026
@ada4a ada4a deleted the unnecessary_map_or-cleanup branch January 12, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @rustbot @Jarcho