Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Jan 10, 2026

changelog: [suspicious_to_owned]: improve lint messages

the suggestions are no longer overlapping?..
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 10, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

- only mention the type once
- put types in backticks
- only highlight the method name in the suggestion
  - removes the need for a snippet
  - makes for finer diffs (seen through `cargo dev lint`)
@ada4a ada4a force-pushed the suspicious_to_owned branch from 8841ea0 to f228056 Compare January 10, 2026 13:13
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

View changes since this review

@llogiq llogiq added this pull request to the merge queue Jan 10, 2026
Merged via the queue into rust-lang:master with commit 8bd0931 Jan 10, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 10, 2026
@ada4a ada4a deleted the suspicious_to_owned branch January 10, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants