overhaul int_plus_one
#16373
Merged
overhaul int_plus_one
#16373
+133
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the need for a wildcard match
Collaborator
By building the whole suggestion in `emit_suggestion`, we avoid the need to thread `Applicability` through `check_binop` into `generate_suggestion`
llogiq
reviewed
Jan 10, 2026
clippy_lints/src/int_plus_one.rs
Outdated
Comment on lines
98
to
104
| if Self::is_one(rhslhs) { | ||
| Some((lhs, rhsrhs)) | ||
| } else if Self::is_one(rhsrhs) { | ||
| Some((lhs, rhslhs)) | ||
| } else { | ||
| None | ||
| } |
Contributor
There was a problem hiding this comment.
We could factor that out into a function we can call with lhs, rhslhs, rhsrhs and below with rhs, lhslhs, lhsrhs.
Contributor
Author
There was a problem hiding this comment.
I thought I could go one step further and create a function for x-1 as well -- do let me know if you think that overabstracts it
reduces duplication
llogiq
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
int_plus_one]: respect reduced applicabilitychangelog: [
int_plus_one]: fix FN with negative literals, e.g.-1 + x <= y