A return in an iterator closure should not trigger never_loop
#16364
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterator never loops when the closure used in, e.g., `.any()`, panics, not when it diverges as a regular `return` lets the iterator continue.
Member
Author
|
The bug was introduced in the current release cycle (1.94) and the lint is warn by default. It might be wise to either apply this PR when approved to the Rust repository before the next beta branch is cut. |
Jarcho
approved these changes
Jan 8, 2026
Member
Author
|
@flip1995 Since the Rustup didn't get through yet, if you get a chance to include this PR which is being merged to Clippy right now, this is great. As a side note, samueltardieu/rust@ce9462f can be applied on top of your current Rustup branch to make |
Member
|
Thanks for providing the fix. I redid the Clippy->Rust sync so this is included 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iterator never loops when the closure used in, e.g.,
.any(), panics, not when it diverges as a regularreturnlets the iterator continue.changelog: [
never_loop]: do not considerreturnas preventing the iterator from loopingFixes #16363
r? @Jarcho