Skip to content

Do not warn on arithmetic side effect for String+String #16358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jarcho merged 1 commit into from
Jan 9, 2026
Merged

Do not warn on arithmetic side effect for String+String #16358

Jarcho merged 1 commit into from
Jan 9, 2026

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jan 8, 2026 •
edited by rustbot
Loading

The previous fix only handled String+str.

changelog: [arithmetic_side_effects]: do not warn on String + String

Fixes #14054 (for good hopefully)

@samueltardieu
Do not warn on arithmetic side effect for String+String
331f75f 
The previous fix only handled `String`+`str`.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@samueltardieu
Copy link
Member Author

samueltardieu commented Jan 8, 2026 •
edited
Loading

This lint should be entirely rewritten, I've opened #16359 for this.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Lintcheck changes for 331f75f

Lint Added Removed Changed
clippy::arithmetic_side_effects 0 8 0

This comment will be updated if you push new changes

Jarcho
Jarcho approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Jan 9, 2026
Merged via the queue into rust-lang:master with commit ea21831 Jan 9, 2026
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 9, 2026
@samueltardieu samueltardieu deleted the issues/14054 branch January 9, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[arithmetic_side_effects] false positive with string and derefs

3 participants

@samueltardieu @rustbot @Jarcho