Skip to content

Fix implicit_saturating_sub suggests wrongly on untyped int literal #16309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jarcho merged 1 commit into from
Jan 1, 2026
Merged

Fix implicit_saturating_sub suggests wrongly on untyped int literal #16309

Jarcho merged 1 commit into from
Jan 1, 2026

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 29, 2025 •
edited by rustbot
Loading

Closes #16307

changelog: [implicit_saturating_sub] fix wrong suggestions on untyped int literal

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Jarcho
Jarcho approved these changes Jan 1, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Jan 1, 2026
Merged via the queue into rust-lang:master with commit 7d41f1d Jan 1, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 1, 2026
@profetia
Copy link
Member Author

profetia commented Jan 1, 2026

Thank you and happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clippy fix creates broken code with saturating sub

3 participants

@profetia @rustbot @Jarcho