Skip to content

Conversation

@borngraced
Copy link
Contributor

lint now correctly detects multiple impl blocks for generic types with identical bounds. Fixes: #16283

changelog: [multiple_inherent_impl]: fix false negatives for generic impl blocks

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Lintcheck changes for ec91742

Lint Added Removed Changed
clippy::multiple_inherent_impl 124 0 5

This comment will be updated if you push new changes

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

View changes since this review

@dswij dswij added this pull request to the merge queue Jan 4, 2026
Merged via the queue into rust-lang:master with commit 6c83a47 Jan 4, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clippy::multiple_inherent_impl should flag generic impl blocks with the same bounds

3 participants