Skip to content

Fix result_large_err FN on closures #16277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jarcho merged 1 commit into from
Dec 24, 2025
Merged

Fix result_large_err FN on closures #16277

Jarcho merged 1 commit into from
Dec 24, 2025

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 20, 2025 •
edited by rustbot
Loading

Closes #16249

changelog: [result_large_err] fix FN on closures

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions
Copy link

github-actions bot commented Dec 20, 2025 •
edited
Loading

Lintcheck changes for 3cf9fa5

Lint Added Removed Changed
clippy::result_large_err 9 0 0

This comment will be updated if you push new changes

Jarcho
Jarcho requested changes Dec 21, 2025
View reviewed changes
clippy_lints/src/functions/result.rs
return;
}

let subject = if is_closure { "closure" } else { "function" };
Copy link
Contributor

@Jarcho Jarcho Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why take a boolean just to convert it to a string?

Copy link
Member Author

@profetia profetia Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not pass a &'static str everywhere, and I think using an enum might be a overkill, so I choose to pass a boolean here

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 21, 2025
@profetia profetia requested a review from Jarcho December 22, 2025 04:47
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 22, 2025
Jarcho
Jarcho approved these changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Dec 24, 2025
Merged via the queue into rust-lang:master with commit 00df684 Dec 24, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

result_large_err does not apply to closures

3 participants

@profetia @rustbot @Jarcho