Skip to content

Do not attempt to use nth with non-usize argument #16272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
llogiq merged 1 commit into from
Dec 20, 2025
Merged

Do not attempt to use nth with non-usize argument #16272

llogiq merged 1 commit into from
Dec 20, 2025

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Dec 20, 2025 •
edited by llogiq
Loading

Fixes #16270

changelog: [needless_collect]: do not attempt to suggest nth when argument is not a usize

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@llogiq llogiq added this pull request to the merge queue Dec 20, 2025
Merged via the queue into rust-lang:master with commit 4181ff5 Dec 20, 2025
15 of 17 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 20, 2025
@samueltardieu samueltardieu deleted the issues/16270 branch December 20, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@llogiq llogiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

needless_collect turns collect::<Vec<_>>()[..] into nth(..).unwrap() turning our slice-cast into an failed indexing attempt

3 participants

@samueltardieu @rustbot @llogiq