Skip to content

Fix new_without_default misses where clause in new #16268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
llogiq merged 1 commit into from
Jan 1, 2026
Merged

Fix new_without_default misses where clause in new #16268

llogiq merged 1 commit into from
Jan 1, 2026

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 20, 2025 •
edited by rustbot
Loading

Closes #16255

changelog: [new_without_default] fix suggestions missing where clause in new

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

llogiq
llogiq approved these changes Dec 20, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general, I just have a very small nit. That won't make too much of a difference, but it won't hurt either.

View changes since this review

@llogiq
Copy link
Contributor

llogiq commented Jan 1, 2026

Looks good to me. Thank you!

@llogiq llogiq added this pull request to the merge queue Jan 1, 2026
Merged via the queue into rust-lang:master with commit 0a983a7 Jan 1, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llogiq llogiq llogiq approved these changes

Assignees

@llogiq llogiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clippy --fix generates broken code for new_without_default when Foo::new has type bounds

3 participants

@profetia @rustbot @llogiq