Skip to content

incompatible_msrv: Don't check the const MSRV for uncalled functions#15795

Merged
samueltardieu merged 1 commit intorust-lang:masterfrom
Jarcho:msrv_const
Oct 29, 2025
Merged

incompatible_msrv: Don't check the const MSRV for uncalled functions#15795
samueltardieu merged 1 commit intorust-lang:masterfrom
Jarcho:msrv_const

Conversation

@Jarcho
Copy link
Copy Markdown
Contributor

@Jarcho Jarcho commented Sep 30, 2025 •
edited by rustbot
Loading

fixes #15792

changelog: [incompatible_msrv]: Don't check the const MSRV for uncalled functions

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Sep 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 30, 2025 •
edited
Loading

No changes for c1de8ed

@Jarcho Jarcho force-pushed the msrv_const branch 2 times, most recently from 0a1b50f to 450cb84 Compare September 30, 2025 18:07
@blyxyas
Copy link
Copy Markdown
Member

blyxyas commented Oct 28, 2025

I currently can't handle any reviews, sorry for the delay. I'll re-rotate and another team member will take this one.
r? clippy

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Oct 28, 2025

Error: assign handler unexpectedly failed in this comment: error decoding response body

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

samueltardieu
samueltardieu approved these changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@samueltardieu samueltardieu added this pull request to the merge queue Oct 29, 2025
Merged via the queue into rust-lang:master with commit 7012a5d Oct 29, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

incompatible_msrv reported even when method is not called

4 participants

@Jarcho @rustbot @blyxyas @samueltardieu