Add configuration option to allow unreachable! in test functions#15517
Open
AMS21 wants to merge 1 commit intorust-lang:masterfrom
Open
Add configuration option to allow unreachable! in test functions#15517AMS21 wants to merge 1 commit intorust-lang:masterfrom
unreachable! in test functions#15517AMS21 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
d00f467 to
329a582
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
Seems that you are trying to add a new configuration option! We are currently in a feature freeze, so we are delaying all lint-adding PRs to September 18 and #15086. Thanks a lot for your contribution, and sorry for the inconvenience. @rustbot note Feature-freeze |
Member
|
r? clippy |
Member
|
What's the motivation here? In my view the combination of a restriction lint & using it enough in tests that a configuration option is better than a one off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
unreachable]: Add configuration option to allow usage in test functionsSummary Notes
Managed by
@rustbot—see help for details