r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Shouldn't we give a better error message? (and use "may cause" since on 16 bit usize platforms this is fine)

For example:

casting `usize` to `f32` may cause a loss of precision (`usize` can be as large as 64 bits wide depending of the target architecture, but `f32`'s mantissa is only 23 bits wide)

Yes, something like that would be even better. I will look over it.

@rustbot author

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Friendly ping from triage: @SLUCHABLUB do you still plan to work on this?

Lintcheck changes for a287c66

This comment will be updated if you push new changes

Yes, sorry.

@rustbot ready

No need to apologize! I try to phrase these in a way that doesn't come off as indicting, but I don't always succeed..

This looks good, just needs a rebase.

@rustbot author

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

It seems that the 32-bit tests are failing. Is there a way for me to run (& bless) them on my 64 bit machine?

Yes, you could cross compile to x86. But I don't think we actually need to incur that complexity here.

I think the 32-bit tests should pass now.

@rustbot ready

@SLUCHABLUB Apply the diff from https://rfc1149.pastes.sh/bless-i686.diff if you wish

Could you squash your commits? Then we'll reattempt the merge.

Thanks for the suggestion, I didn't see it until now so I just blessed them from a 32-bit qemu instance. Nonetheless, it should work now.

Will try to squash.

Sorry if this is the wrong place to ask, but where is it documented that usize will not be larger than 64 bits? There is no From<usize> for u128 impl and https://doc.rust-lang.org/stable/std/primitive.usize.html does not mention this.

Whilst it in theory can have any size (greater than or equal to 16 bits), in practice (on all supported targets) it only ever goes up to 64 bits.