Move codegen postprocessing to its own module#2282
Merged
pvdrz merged 9 commits intorust-lang:masterfrom Sep 27, 2022
Merged
Conversation
emilio
approved these changes
Sep 24, 2022
Contributor
emilio
left a comment
There was a problem hiding this comment.
This looks great, thanks!
I have one suggestion that avoids some of the macro soup, let me know what you think. I implemented it in 0798bda.
I think it's a bit easier to follow, if you agree feel free to cherry-pick that on top before merging.
Thanks again!
Contributor
Author
@emilio, that's a pretty cool pattern! I'm going to steal it 😬 I did some changes to your commit so |
This was referenced Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all the
synbased postprocessing to its own module insidecodegen.