Add an option for extra env vars in the Code extension#7091
Merged
bors[bot] merged 1 commit intorust-lang:masterfrom Dec 30, 2020
Merged
Add an option for extra env vars in the Code extension#7091bors[bot] merged 1 commit intorust-lang:masterfrom
bors[bot] merged 1 commit intorust-lang:masterfrom
Conversation
matklad
reviewed
Dec 30, 2020
editors/code/package.json
Outdated
| "default": null, | ||
| "markdownDescription": "Path to rust-analyzer executable (points to bundled binary by default). If this is set, then `#rust-analyzer.updates.channel#` setting is not used" | ||
| }, | ||
| "rust-analyzer.serverExtraEnv": { |
Contributor
There was a problem hiding this comment.
Suggested change
| "rust-analyzer.serverExtraEnv": { | |
| "rust-analyzer.server.extraEnv": { |
we'll migrate serverPath later
matklad
reviewed
Dec 30, 2020
Contributor
matklad
left a comment
There was a problem hiding this comment.
r=me with config renamed
bors d+
Contributor
|
✌️ lf- can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging some issues with the RA extension around getting
cargo checkto work and it was particularly frustrating to get the RA_LOG variable set on the server since I had to change it in a login file. This should make that easier.