Skip to content

Switch to env var CARGO_RESOLVER_LOCKFILE_PATH for copied lockfiles for toolchains >= 1.95.0#21630

Merged
ShoyuVanilla merged 2 commits intorust-lang:masterfrom
ShoyuVanilla:cargo-lockfile
Feb 18, 2026
Merged

Switch to env var CARGO_RESOLVER_LOCKFILE_PATH for copied lockfiles for toolchains >= 1.95.0#21630
ShoyuVanilla merged 2 commits intorust-lang:masterfrom
ShoyuVanilla:cargo-lockfile

Conversation

@ShoyuVanilla
Copy link
Copy Markdown
Member

Resolves #21614

@ShoyuVanilla
Copy link
Copy Markdown
Member Author

I think the implementation is done but opening this as a draft to test if this works without any problem by myself.
Yeah, we need to implement more sophisticated test infra for cargo and flycheck things 😅

Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update!

@Veykril
Copy link
Copy Markdown
Member

Veykril commented Feb 14, 2026

on that note, do we use the lockfile stuff for flycheck? 🤔 (if not we should probably look into doing that)

@ShoyuVanilla
Copy link
Copy Markdown
Member Author

on that note, do we use the lockfile stuff for flycheck? 🤔 (if not we should probably look into doing that)

No, I just realized that we are not doing it yet 😮

@ShoyuVanilla
Copy link
Copy Markdown
Member Author

I've just tested this and realized that we need -Zlockfile-path 😅

@ShoyuVanilla ShoyuVanilla marked this pull request as ready for review February 18, 2026 17:18
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2026
@ShoyuVanilla
Copy link
Copy Markdown
Member Author

Merging based on approvals 😄

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Feb 18, 2026
Merged via the queue into rust-lang:master with commit 19e8d96 Feb 18, 2026
16 checks passed
@ShoyuVanilla ShoyuVanilla deleted the cargo-lockfile branch February 18, 2026 18:28
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2026
@boozook
Copy link
Copy Markdown

boozook commented Feb 28, 2026

I've got new one with --lockfile-path:

Failed to read Cargo metadata with dependencies for `/Users/_/project/Cargo.toml`: `cargo metadata` exited with an error: error: unexpected argument '--lockfile-path' found
  • rust-analyzer 1.95.0-nightly (3a70d034 2026-02-27)
  • rustc 1.95.0-nightly (3a70d0349 2026-02-27)

Originally posted in #21510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to env var CARGO_RESOLVER_LOCKFILE_PATH for copied lockfiles

5 participants