Skip to content

Conversation

@SomeoneToIgnore
Copy link
Contributor

docs_refs.mov

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2025
@ChayimFriedman2
Copy link
Contributor

I have a concern: this does not find the most obvious reference - where the cursor is. And all other references in doc comments.

@SomeoneToIgnore
Copy link
Contributor Author

My main use case for the current impl is to look up code whilst keeping the view of the documentation in the current editor, and did not expect the documentation links to appear there.

Also, I suspect that if we start showing all docs' references, that will make the reference lookup even slower and bloated with results?

So, personally, I'd love to keep things as they are, as I am rarely interested in docs' usages, but very interested in the real code related.

I do not know internals good enough, but suspect that if we want to track those references in docs as proposed, we need to go over almost all the "stack" starting with lowering?
I'm not sure I will be able to do that, and neither I am interested right now: I want to make completions to work inside doc comments and this was a practice PR before that.

@Veykril
Copy link
Member

Veykril commented Dec 31, 2025

I have a concern: this does not find the most obvious reference - where the cursor is. And all other references in doc comments.

This would be ideal behavior, but shouldn't block this PR. Its an improvement over the current state after all.

@Veykril Veykril added this pull request to the merge queue Dec 31, 2025
Merged via the queue into rust-lang:master with commit a9026e6 Dec 31, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2025
@SomeoneToIgnore SomeoneToIgnore deleted the doc-find-defs branch December 31, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants