fix: Expand literals with wrong suffixes into LitKind::Err#20963
Merged
Veykril merged 1 commit intorust-lang:masterfrom Nov 3, 2025
Merged
fix: Expand literals with wrong suffixes into LitKind::Err#20963Veykril merged 1 commit intorust-lang:masterfrom
LitKind::Err#20963Veykril merged 1 commit intorust-lang:masterfrom
Conversation
4f0d1ef to
00b4138
Compare
00b4138 to
a0217d8
Compare
Veykril
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20952
For ill-suffixed literals like
""б(Not a number6😅), we pass it asfmt_snippethere:rust-analyzer/crates/hir-def/src/hir/format_args.rs
Line 197 in 00b627d
But in that function the following line panics if the string literal has the suffix ending with a
char::len_utf8() > 1https://doc.rust-lang.org/1.91.0/nightly-rustc/src/rustc_parse_format/lib.rs.html#319
We might limplement some diagnostics or error recovery upon those ill-suffixed string literals but that's not quite doable without some non-trivial refactoring in our parser/token tree/expansion infra. The simplest fix would be just erroring on those literals