Remove redundant associated type bounds from dyn TypeFolder#18577
Merged
lnicola merged 1 commit intorust-lang:masterfrom Nov 30, 2024
Merged
Remove redundant associated type bounds from dyn TypeFolder#18577lnicola merged 1 commit intorust-lang:masterfrom
dyn TypeFolder#18577lnicola merged 1 commit intorust-lang:masterfrom
Conversation
lnicola
approved these changes
Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a redundant associated type bound from the return type of
TypeFolder::as_dynin some impls. This associated type is already constrained by the definition oftrait TypeFolder:And so specifying it is unnecessary.
Removing this bound may also be necessary to avoid unintended breakage while fixing rust-lang/rust#133361, though this usage is not unsound, it's just hard to support while also fixing the underlying issue.