internal: Include buildfiles in VFS#18192
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 27, 2024
Merged
Conversation
2924b50 to
85ca217
Compare
davidbarsky
requested changes
Sep 26, 2024
davidbarsky
approved these changes
Sep 27, 2024
Contributor
davidbarsky
left a comment
There was a problem hiding this comment.
LGTM, but I won't bors this for conflict of interest reasons.
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We subscribe to
textDocument/didSaveforfilesToWatch, but the VFS doesn't contain those files. Before #18105, this would bring down the server. Now, it's only a benign error logged:It's benign, because we will also receive a
workspace/didChangeWatchedFilesfor the file which will invalidate and load it.Explicitly include the buildfiles in the VFS to prevent the handler from erroring.