fix: Remove accidental dependency between parse_macro_expansion and parse#16775
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 7, 2024
Merged
fix: Remove accidental dependency between parse_macro_expansion and parse#16775bors merged 1 commit intorust-lang:masterfrom
parse_macro_expansion and parse#16775bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Author
|
@bors r+ |
Contributor
parse_macro_expansion and parseparse_macro_expansion and parse
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out my idea from #15251 causes all builtin derive expansions to obviously rely on the main parse, meaning the entire
macro_arglayer becomes kind of pointless. So this reverts that PR again.