Skip to content

Revert "Use ZWNJ to prevent VSCode from forming ligatures between hints and code"#13923

Merged
bors merged 1 commit into
masterfrom
revert-13886-inlay-ligatures
Jan 10, 2023
Merged

Revert "Use ZWNJ to prevent VSCode from forming ligatures between hints and code"#13923
bors merged 1 commit into
masterfrom
revert-13886-inlay-ligatures

Conversation

@Veykril

@Veykril Veykril commented Jan 10, 2023

Copy link
Copy Markdown
Member

Doesn't actually seem to fix the bug, it seems to be theme dependent and I am not sure what causes it
Reverts #13886

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2023
@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 4267b11 has been approved by lnicola

It is now in the queue for this repository.

@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4267b11 with merge 6e89e77...

@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 6e89e77 to master...

@bors bors merged commit 6e89e77 into master Jan 10, 2023
@bors bors deleted the revert-13886-inlay-ligatures branch January 10, 2023 17:22
@AaronKutch

Copy link
Copy Markdown

This (?) fixed the issue I had

@Veykril

Veykril commented Jan 12, 2023

Copy link
Copy Markdown
Member Author

This was the cause for your problem, it no longer occurs for me either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants