Skip to content

Fix obsolete config keys#12742

Merged
bors merged 6 commits intorust-lang:masterfrom
TonalidadeHidrica:fix-obsolete-config-keys
Jul 13, 2022
Merged

Fix obsolete config keys#12742
bors merged 6 commits intorust-lang:masterfrom
TonalidadeHidrica:fix-obsolete-config-keys

Conversation

@TonalidadeHidrica
Copy link
Contributor

@TonalidadeHidrica TonalidadeHidrica commented Jul 11, 2022 •
edited
Loading

The config keys were drastically reorganized by #12010, but the docs don't reflect the updates, causing inconsistency and confusion. I checked for such obsolete configuration keys and updated to the new one. For reproducibility, I attach a small shell script that I used to examine the old keys. Now the script only detects cargoExtraArgs and overrideCargo, which originates from other type definition in the code but not from the configuration.

script 
echo "allowMergingIntoGlobImports
exprFillDefault
importEnforceGranularity
importGranularity
importMergeBehavior
importMergeBehaviour
importGroup
importPrefix
warmup
loadOutDirsFromCheck
runBuildScripts
runBuildScriptsCommand
useRustcWrapperForBuildScripts
enableExperimental
procAttrMacros
breakPoints
exitPoints
yieldPoints
linksInHover
linksInHover
gotoTypeDef
chainingHints
closureReturnTypeHints
hideNamedConstructorHints
parameterHints
reborrowHints
typeHints
lruCapacity
cargoExtraArgs
overrideCargo
rustcSource
enableRangeFormatting
assist\.allowMergingIntoGlobImports
assist\.exprFillDefault
assist\.importEnforceGranularity
assist\.importGranularity
assist\.importMergeBehavior
assist\.importMergeBehaviour
assist\.importGroup
assist\.importPrefix
primeCaches\.enable
cache\.warmup
cargo\.loadOutDirsFromCheck
cargo\.runBuildScripts
cargo\.runBuildScriptsCommand
cargo\.useRustcWrapperForBuildScripts
completion\.snippets
diagnostics\.enableExperimental
experimental\.procAttrMacros
highlighting\.strings
highlightRelated\.breakPoints
highlightRelated\.exitPoints
highlightRelated\.yieldPoints
highlightRelated\.references
hover\.documentation
hover\.linksInHover
hoverActions\.linksInHover
hoverActions\.debug
hoverActions\.enable
hoverActions\.gotoTypeDef
hoverActions\.implementations
hoverActions\.references
hoverActions\.run
inlayHints\.chainingHints
inlayHints\.closureReturnTypeHints
inlayHints\.hideNamedConstructorHints
inlayHints\.parameterHints
inlayHints\.reborrowHints
inlayHints\.typeHints
lruCapacity
runnables\.cargoExtraArgs
runnables\.overrideCargo
rustcSource
rustfmt\.enableRangeFormatting
allFeatures
addCallArgumentSnippets
addCallParenthesis
callInfo\.full
cargo\.allFeatures
checkOnSave\.allFeatures
completion\.addCallArgumentSnippets
completion\.addCallParenthesis" | while read -r pattern
do
  rg '\b'$pattern'\b([^.]|$)' . -g "!crates/rust-analyzer/src/config/patch_old_style.rs" -g "!editors/code/src/config.ts" -g "!a.sh" --no-heading --color=always --line-number
done

exit

excluded
# debug
# enable
# run
# implementations
# references
# documentation
# references
# snippets
# strings
# full

@Veykril
Copy link
Member

Veykril commented Jul 13, 2022

Thank you very much! This completely slipped my mind.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 13, 2022

📌 Commit e3bde57 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 13, 2022

⌛ Testing commit e3bde57 with merge 84a6bc9...

@bors
Copy link
Contributor

bors commented Jul 13, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 84a6bc9 to master...

@bors bors merged commit 84a6bc9 into rust-lang:master Jul 13, 2022
@TonalidadeHidrica
Copy link
Contributor Author

TonalidadeHidrica commented Jul 18, 2022

When will the online manual be updated?

@lnicola
Copy link
Member

lnicola commented Jul 18, 2022

Soon 🙂.

@TonalidadeHidrica TonalidadeHidrica deleted the fix-obsolete-config-keys branch July 18, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TonalidadeHidrica @Veykril @bors @lnicola