Skip to content

feat: Make inlay hints work in some attributed items#10274

Merged
bors[bot] merged 1 commit into
rust-lang:masterfrom
Veykril:inlay-hints-attr
Sep 18, 2021
Merged

feat: Make inlay hints work in some attributed items#10274
bors[bot] merged 1 commit into
rust-lang:masterfrom
Veykril:inlay-hints-attr

Conversation

@Veykril

@Veykril Veykril commented Sep 18, 2021

Copy link
Copy Markdown
Member

Second attempt at #10043(previous attempt #10231), still doesn't seem to work in every case...
image
Slight difference to the first approach, chaining hints now work but attribute inputs do not as they are basically the same as normal macros in that they take a token tree.

Fixes #10043

@Veykril

Veykril commented Sep 18, 2021

Copy link
Copy Markdown
Member Author

Well that's odd, the test passes but it doesn't work 🤔
Turns out you gotta make sure you are running the right server binary...

@Veykril

Veykril commented Sep 18, 2021

Copy link
Copy Markdown
Member Author

bors r+

@bors

bors Bot commented Sep 18, 2021

Copy link
Copy Markdown
Contributor

@bors bors Bot merged commit ba16c16 into rust-lang:master Sep 18, 2021
@Veykril Veykril deleted the inlay-hints-attr branch September 18, 2021 11:52
@Veykril Veykril changed the title feat: Make inlay hints work in attributed items feat: Make inlay hints work in some attributed items Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inlay hints should work in attributed items with bodies

1 participant