Merged
Conversation
Stage 1 check has been supported since rust-lang#81064. rust-lang#81064 changed the error message for this, but I don't think there's any reason we should prevent using it. I tested locally and `keep-stage` works fine. Don't give a hard error when trying to use it.
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Fixes a warning:
warning: llvm-wrapper/RustWrapper.cpp:159:11: warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch [-Wswitch]
warning: switch (Kind) {
warning: ^
Which was fall out from 130a1df.
When we're downloading based on a CI commit, that can still be -beta- or even -stable-, so we should lookup the channel it was built with.
…ulacrum Support `x --keep-stage 0 check` Stage 1 check has been supported since rust-lang#81064. rust-lang#81064 changed the error message for this, but I don't think there's any reason we should prevent using it. I tested locally and `keep-stage` works fine. r? `@Mark-Simulacrum`
…gs-webcomponents, r=GuillaumeGomezp rustdoc: align invalid-html-tags lint with commonmark spec
Remove `parent_pat` from `TopInfo` We can get the parent pat from the hir map.
Do not allow bad projection term to leak into the type checker Fixes rust-lang#99828
…7, r=joshtriplett Reset directory iteration in remove_dir_all Fixes rust-lang#99934
…lan-DPC Remove more Clean trait implementations This time it even allowed to remove a function. Follow-up of rust-lang#99638. r? `@notriddle`
…uviper
Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE
Fixes a warning:
```
warning: llvm-wrapper/RustWrapper.cpp:159:11: warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch [-Wswitch]
warning: switch (Kind) {
warning: ^
```
Which was fall out from 130a1df.
Fixes rust-lang#99955
…channel, r=jyn514 Discover channel for LLVM download r? `@jyn514` cc `@RalfJung` Reported on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/No.20prebuilt.20LLVM.20for.20the.20beta.20branch.3F
Member
Author
|
@bors r+ rollup=never p=10 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (0f4bcad): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x --keep-stage 0 check#99650 (Supportx --keep-stage 0 check)parent_patfromTopInfo#99889 (Removeparent_patfromTopInfo)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup