Skip to content

Make some clean::Trait fields computation on demand#99598

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:clean-trait-fields-on-demand
Jul 22, 2022
Merged

Make some clean::Trait fields computation on demand#99598
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:clean-trait-fields-on-demand

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 22, 2022

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 22, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2022
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 22, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 22, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2022
@bors
Copy link
Collaborator

bors commented Jul 22, 2022

⌛ Trying commit edb9add with merge 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a...

@bors
Copy link
Collaborator

bors commented Jul 22, 2022

☀️ Try build successful - checks-actions
Build commit: 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a (9cf9c1165517fc1279f15f86fa4e2364e0e52e8a)

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 22, 2022

Queued 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a with parent e7a9c11, future comparison URL.

notriddle
notriddle approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if it's not a perf regression

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 22, 2022

Finished benchmarking commit (9cf9c1165517fc1279f15f86fa4e2364e0e52e8a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.9% -4.3% 2
Improvements 🎉
(secondary)		 -2.6% -3.1% 5
All 😿🎉 (primary) -3.9% -4.3% 2

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.3% -2.3% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2022
@notriddle
Copy link
Contributor

notriddle commented Jul 22, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 22, 2022

📌 Commit edb9add has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022
@bors
Copy link
Collaborator

bors commented Jul 22, 2022

⌛ Testing commit edb9add with merge ffa7733...

@bors
Copy link
Collaborator

bors commented Jul 22, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing ffa7733 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2022
@bors bors merged commit ffa7733 into rust-lang:master Jul 22, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 22, 2022
@bors bors mentioned this pull request Jul 22, 2022
Merged
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 22, 2022

Finished benchmarking commit (ffa7733): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 3.1% 3.1% 1
Regressions 😿
(secondary)		 4.4% 5.9% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 3.1% 3.1% 1

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.1% 3.1% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@GuillaumeGomez GuillaumeGomez deleted the clean-trait-fields-on-demand branch October 24, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez @rustbot @rust-timer @bors @notriddle @rust-highfive