Skip to content

[perf experiment] Revert "Rollup merge of #99213 - davidtwco:translation-migrate-passes…#99370

Closed
matthiaskrgr wants to merge 3 commits intorust-lang:masterfrom
matthiaskrgr:rev_transl
Closed

[perf experiment] Revert "Rollup merge of #99213 - davidtwco:translation-migrate-passes…#99370
matthiaskrgr wants to merge 3 commits intorust-lang:masterfrom
matthiaskrgr:rev_transl

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jul 17, 2022

…, r=compiler-errors"

This reverts commit 79857a7, reversing
changes made to 6f8fb91.

r? @ghost

@matthiaskrgr
Revert "Rollup merge of rust-lang#99213 - davidtwco:translation-migra…
31c431f 
…te-passes, r=compiler-errors"

This reverts commit 79857a7, reversing
changes made to 6f8fb91.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 17, 2022
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 17, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 17, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 17, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 17, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 17, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 17, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 17, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 17, 2022

⌛ Trying commit 168778f with merge e430ffbf2a58889d8be3917a531de2517c3a6514...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 17, 2022

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 17, 2022
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 17, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 17, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jul 17, 2022

⌛ Trying commit 332068d with merge d63ac6f7e6f3e9c134727d3f6fa4a5bcf036bdd6...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jul 17, 2022

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling rustc_save_analysis v0.0.0 (/checkout/compiler/rustc_save_analysis)
error: the feature `let_chains` has been stable since 1.64.0 and no longer requires an attribute to enable
  --> compiler/rustc_passes/src/lib.rs:11:12
   |
11 | #![feature(let_chains)]
   |
   |
   = note: `-D stable-features` implied by `-D warnings`
error: could not compile `rustc_passes` due to previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:07:49

@bors
Copy link
Collaborator

bors commented Jul 17, 2022

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jul 17, 2022

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling rustc_save_analysis v0.0.0 (/checkout/compiler/rustc_save_analysis)
error: the feature `let_chains` has been stable since 1.64.0 and no longer requires an attribute to enable
  --> compiler/rustc_passes/src/lib.rs:11:12
   |
11 | #![feature(let_chains)]
   |
   |
   = note: `-D stable-features` implied by `-D warnings`
[RUSTC-TIMING] rustc_passes test:false 1.632
error: could not compile `rustc_passes` due to previous error
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] rustc_symbol_mangling test:false 18.598

@matthiaskrgr matthiaskrgr mentioned this pull request Jul 17, 2022
Merged
@matthiaskrgr matthiaskrgr deleted the rev_transl branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthiaskrgr @rust-timer @rust-log-analyzer @bors @rustbot