Fix missing modules because of missing unindent doc comment in early intra-doc pass#96216
Closed
GuillaumeGomez wants to merge 2 commits intorust-lang:masterfrom
Closed
Fix missing modules because of missing unindent doc comment in early intra-doc pass#96216GuillaumeGomez wants to merge 2 commits intorust-lang:masterfrom
GuillaumeGomez wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
Some changes occurred in cc @camelid |
Contributor
|
This fix is already a part of #96135. |
Member
Author
|
Please include my second commit then (the one containing the regression test). Once done, please close this PR. :) |
Contributor
|
I've cherry-picked the test commit into #96135, so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96079.
Copying/pasting my explanation from #96079:
I didn't find a way to be able to run the
unindentpass before the early intra-doc link pass unfortunately, so instead I check beforehand if there is a point into looking for a link instead the doc comment before doing anything. Hopefully, this shouldn't impact performance too much...cc @petrochenkov
r? @notriddle