Resolve documentation links in rustc and store the results in metadata by petrochenkov · Pull Request #94857 · rust-lang/rust

petrochenkov · 2022-03-11T17:34:47Z

This PR implements MCP rust-lang/compiler-team#584.

Doc links are now resolved in rustc and stored into metadata, so rustdoc simply retrieves them through a query (local or extern),

Code that is no longer used is removed, and some code that no longer needs to be public is privatized.
The removed code includes resolver cloning, so this PR fixes #83761.

petrochenkov · 2022-03-11T17:35:08Z

@bors try @rust-timer queue

rust-timer · 2022-03-11T17:35:09Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-03-11T17:35:19Z

⌛ Trying commit 2cf9c82db92b289f797a3639fa66646a7f7f7c59 with merge 4ba03cc378a00f3aa7982e3b28bf1be1ee8b5bb1...

jyn514

This is awesome ❤️ thank you so much for pushing this through.

compiler/rustc_resolve/src/lib.rs

src/librustdoc/core.rs

src/librustdoc/passes/collect_intra_doc_links/early.rs

src/test/rustdoc-ui/intra-doc/ambiguity.stderr

petrochenkov · 2022-03-11T20:29:09Z

@jyn514
This is far from being ready for review, I posted the PR in hope to get some upper limit on performance regressions.
So the answer to all of the review comments so far is "what did you expected from an in progress work".

petrochenkov · 2022-03-18T21:37:22Z

@bors try @rust-timer queue

rust-timer · 2022-03-18T21:37:23Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-03-18T21:37:29Z

⌛ Trying commit a212f3f85fc2474fce8a7c6cf94f577a9a3cf558 with merge aa6d1b03317847cb190fc37c0d4674bf18f3a192...

petrochenkov · 2023-02-10T10:25:35Z

10 days since rust-lang/compiler-team#584 (comment) has passed.
@bors r=oli-obk

bors · 2023-02-10T10:25:37Z

📌 Commit da4ce6b has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-02-10T13:45:03Z

⌛ Testing commit da4ce6b with merge f62035c6ee2f0da5b333bc92b4a26511557557ad...

oli-obk · 2023-02-10T15:33:04Z

@bors retry msvc PGO: error: no profile can be merged

bors · 2023-02-11T01:01:11Z

⌛ Testing commit da4ce6b with merge 9bc50985a9890937eb5cab7ba53a63c1d85eb336...

petrochenkov · 2023-02-11T07:39:27Z

It's llvm-profdata again.
It does look spurious because it was encountered in other PRs too, e.g. in #107434.
@bors retry

bors · 2023-02-11T12:10:20Z

⌛ Testing commit da4ce6b with merge 5b45024...

bors · 2023-02-11T15:04:20Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 5b45024 to master...

rust-timer · 2023-02-11T17:25:13Z

Finished benchmarking commit (5b45024): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.3%, 1.5%]	28
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-2.4%	[-5.7%, -0.6%]	17
Improvements ✅ (secondary)	-3.4%	[-5.2%, -0.6%]	21
All ❌✅ (primary)	-0.6%	[-5.7%, 1.5%]	45

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[1.2%, 4.2%]	3
Improvements ✅ (primary)	-4.5%	[-7.9%, -1.9%]	15
Improvements ✅ (secondary)	-2.6%	[-8.1%, -1.3%]	20
All ❌✅ (primary)	-4.5%	[-7.9%, -1.9%]	15

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-3.0%	[-4.9%, -1.8%]	10
Improvements ✅ (secondary)	-3.7%	[-4.7%, -1.7%]	17
All ❌✅ (primary)	-2.6%	[-4.9%, 2.0%]	11

rylev · 2023-02-14T16:25:28Z

Going to label this as perf triaged based on the analysis here.

@rustbot label: perf-regression-triaged

rust-highfive assigned camelid Mar 11, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2022

petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022

This comment has been minimized.

Sign in to view