Merged
Conversation
(hir::Map only consists of a single reference anyways)
For cg_llvm update_symbols merely sets a flag, so changing the position or removing an additional call doesn't have any effect.
All paths to an ArchiveBuilder::build call update_symbols first.
…ns, r=matthewjasper Erase regions before calculating layout for packed field capture Self-explanatory. We just erase region inferencing because we don't need that for layout computation... Q: layouts are always equal modulo regions, right? Fixes rust-lang#92240
…, r=cjgillot Add comment on stable_hash_impl for OwnerNodes r? `@cjgillot` cc `@oli-obk` `@bors` rollup=always
…plete, r=pietroalbini Drop rustc-docs from complete profile Addresses rust-lang#75833, but does not fully fix it -- we should support side-by-side installation of these ideally, but that's not currently possible. r? `@pietroalbini`
…r=jsha rustdoc: remove support for multi-query search This is needed by rust-lang#90630 to make feature changes non-existent. cc `@camelid` r? `@jsha`
Make all `hir::Map` methods consistently by-value `hir::Map` only consists of a single reference (as part of the contained `TyCtxt`) anyways, so copying is literally zero overhead compared to passing a reference
Fix ICE if no trait assoc const eq Fixes rust-lang#93835
…roalbini Split x86_64-apple builder into two This splits out roughly 20-25 minutes of work, which should result in roughly parity with some of the other apple builders at approximately 2.2-2.4 hours per successful build. r? `@pietroalbini`
…petrochenkov Remove ArchiveBuilder::update_symbols All paths to an ArchiveBuilder::build call update_symbols first.
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
|
📌 Commit c543f7d has been approved by |
Collaborator
|
⌛ Testing commit c543f7d with merge 0899ffb833107222149fe6b1373e85f3aa31b283... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
|
@bors retry something on msvc but it doesn't show any logs |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (78450d2): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
hir::Mapmethods consistently by-value #93853 (Make allhir::Mapmethods consistently by-value)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup